Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broker restart resets counters to 0 #913

Conversation

kbatuigas
Copy link
Contributor

@kbatuigas kbatuigas commented Dec 10, 2024

Description

  • Also includes some minor reworking of the Monitor Redpanda doc overview

Resolves https://github.com/redpanda-data/documentation-private/issues/2452
Review deadline: 12 Dec 2024

Page previews

Monitor Redpanda > Monitor for performance and health

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit 0801565
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/67604ebddd7caf000818c2a4
😎 Deploy Preview https://deploy-preview-913--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kbatuigas kbatuigas force-pushed the DOC-246-Call-out-that-Metrics-Counters-will-reset-to-Zero-on-a-broker-restart branch from f278dbc to b20474c Compare December 10, 2024 22:32
@kbatuigas kbatuigas marked this pull request as ready for review December 11, 2024 16:01
@kbatuigas kbatuigas requested a review from a team as a code owner December 11, 2024 16:01
@@ -1,8 +1,6 @@
Redpanda exports metrics through Prometheus endpoints for you to monitor system health and optimize system performance.
Redpanda exports metrics through two Prometheus endpoints on the Admin API port (default: 9644) for you to monitor system health and optimize system performance.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wzzzrd86 @masapanda is it correct that we call out "Prometheus" here?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that is correct

Copy link
Contributor

@Deflaimun Deflaimun Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you solved this already, but just for the future, I don't think calling it "prometheus endpoints" is accurate. They're HTTP endpoints, through the Admin API, that the response body with a prometheus format.

@kbatuigas
Copy link
Contributor Author

Note: need to reset to discard package-lock.json changes

@kbatuigas kbatuigas force-pushed the DOC-246-Call-out-that-Metrics-Counters-will-reset-to-Zero-on-a-broker-restart branch from 88a1676 to c9e9f20 Compare December 11, 2024 19:30
Copy link
Contributor

@micheleRP micheleRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left a couple suggestions to consider.

Copy link

@wzzzrd86 wzzzrd86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kbatuigas kbatuigas merged commit 06da0e3 into main Dec 16, 2024
3 checks passed
@kbatuigas kbatuigas deleted the DOC-246-Call-out-that-Metrics-Counters-will-reset-to-Zero-on-a-broker-restart branch December 16, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants